-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentSpawn functionality #3086
sentSpawn functionality #3086
Conversation
Moved casting and typeIdToString to E2Lib and WireLib. Fixed major bug, where registered sents didn't check for prop protection, when creating constrains. Changed comments a bit
Looks fine, might do a diff against starfall's to sanity check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sents_default_params.lua needs to be put somewhere outside of lua/entities. putting lua files there registers the filename as an entity class.
Diffed the changes and they mostly look ok. The gmod_wire_value code is pretty messy, but whatever. |
Moved sents_default_params.lua Renamed sents_default_params.lua Changed the way to block sents, and renamed whitelist to registry, to reinforce reusability for thirdparty addons
Regarding gmod_wire_value code is messy because I didn't like how it was implemented in sf, so I've decided to expand the value setting logic, while leaving support for the sf way. Code is messy, but I'm not sure how to make it cleaner without separating logic into few, never reused functions out of gmod_wire_value's preFactory. I think it's fine to leave it as is for now, as it will not really harm any future work, and maybe someday someone, or me, will refactor that. |
(Re-PR because I accidentally deleted previous fork)
Added
:GetBool()
, and review changes.wire_expression2_propcore_whitelist <= 0
)Expression2_CanEffect
While most of registration code/logic is from starfall
prop_sent.lua
, I've found and fixed ~10 sents + added ~6 that weren't originally there.Current minor bugs:
E2 sent (classname)
, bute2_spawned_sent
when user cancels sent.