Stop marking R0-R31 as needing interrupt checks #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using ZVM Test Suite's Benchmarking 5 runs without this change (Avg across the 5 runs showed 3.549 seconds) 5 runs with this change (Avg across the 5 runs showed 3.293 seconds) Seems like an average speed increase of 7% (ran in-game, dedicated server may show different) |
thegrb93
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For R0-R31 being used as a register, previously it would do an interrupt check as if it were a memory access, this will no longer be the case and R0-R31 access (as registers, not using them for memory access) will no longer use interrupt checks, bringing them to an equal performance as using the regular(EAX, EBX, etc.) registers.