E2Helper & Text Editor Module Support #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
approved these changes
Sep 3, 2024
|
One small issue with the debugger I need to fix at some point, it seems like the cpulib debugger prepends cpuchip to the current open file name if I have the debugger on a cpu and open a gpu file |
|
That'll probably be the last of the work I need to do for this, after review it should be ready for merge alongside the PR in wire-main |
thegrb93
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support for the upcoming changes in wiremod/wire#3127 by porting some of the functionality of the original E2Helper implementation for ZCPU here.
The changes allow loaded extensions to display their instructions properly in E2Helper thanks to being able to update descriptions and items at CPULib's will.
Backwards compatible with older versions of wiremod before this change, letting the hardcoded E2Helper & Text Editor control us, but the new version of wiremod won't be able to support versions of ZCPU before this, sadly.
(this is what it'll look like for an older zcpu version on new wiremod, still compiles when you click but no syntax highlighting or helper, technically functional)
