LOOPB now ends on 0 instead of -1 like other loops #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOOPB was referencing VM.EBX for its ~= 0 condition and not EBX, the local copy that was modified during this call, which meant it was the value before the decrement and not after the decrement.
Documentation of LOOPB was worded the same as LOOPA, LOOPC, LOOP, and LOOPD, which makes me further believe LOOPB's behavior was in error.
Also technically boosts performance of LOOPB,, because it's not indexing EBX from VM twice anymore and is now properly using the local version, same as the other LOOP instructions are.