Extension Lua Instructions w/ flag can now break precompile #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instructions in ZVM are branching, they need to set PrecompileBreak on the VM to end the compilation early, this ends the function and when the compiled block is run, any calls to VM:Jump will set VM.IP and be allowed to take effect, since VM.IP won't change as the block runs.
Uses the CB and UB flags to alter this behavior on a per instruction basis at initial load of extension.
So if you flag your function as being Conditionally Branched or Unconditionally Branched when using ext:InstructionFromLuaFunc your function will be able to call VM:Jump and have it take effect properly.