MLOOKAT and DWRITEFMT fixed #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
reviewed
Dec 11, 2023
lua/wire/zvm/zvm_opcodes.lua
Outdated
| self:Dyn_Emit("$L EYE = VM:ReadVector3f($2 + %s+0",seg2code) | ||
| self:Dyn_Emit("$L CENTER = VM:ReadVector3f($2 + %s+3",seg2code) | ||
| self:Dyn_Emit("$L UP = VM:ReadVector3f($2 + %s+6",seg2code) | ||
| self:Dyn_Emit("$L EYE = VM:ReadVector3f($2 + VM."..(self.EmitOperandSegment[2] or "DS").."+0)") |
There was a problem hiding this comment.
These can still use %s right?
There was a problem hiding this comment.
Actually yeah, that was how I fixed it initially(just adding the right parenthesis), I think I copy & pasted the original lines to test if the behavior was the same and forgot to put the fixed ones that use seg2code back, thank you for spotting that
thegrb93
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #34
MLOOKAT was missing a ) for its first three dyn_emits (this fixes all the 3d examples)
DWRITEFMT needed to have its % string checks replaced with %%%% to get them through the string.formats on Dyn_Emit and Emit, and a % operator use replaced with math.mod