Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZCPU Compile-time warnings can now be displayed in the editor + pragma for muting them #16

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

DerelictDrone
Copy link
Member

@DerelictDrone DerelictDrone commented Nov 13, 2023

Quite frankly this was an overdue addition, as up to this point most users may not have ever known that warnings were in the console, this provides a quick and easy way to jump to said warnings, and makes the addition of new warnings more meaningful from here on out since everyone will see them(unless they use the handy dandy pragma commands I've added to silence them)

Displays filename for includes with warnings in them
image

Furthermore, included file warnings are accurate to where the warning is in the included file, though you can't automatically jump into the file by double clicking on external file warnings, you can jump to the line/col if you open the file manually
image

Additionally, you can silence editor warnings on a per-file basis using
#pragma silence self - Mutes warnings generated by code in this file
selfmute

#pragma silence includes - Mutes warnings generated by code in the files directly included by this file
othermute

Aliases for these pragma commands include
[silence, mute] for pragma name
[includes, other] for pragma parameter (to mute only warnings in any files included from this one)
[self] for pragma parameter (to mute only warnings in this file)

@Denneisk
Copy link
Member

You're doing great work here

@DerelictDrone
Copy link
Member Author

DerelictDrone commented Nov 13, 2023

I tested it on my own after fixing the merge conflict and it seems like functionality is still there with in a code file that uses both, idk why the lint check failed

@Vurv78
Copy link
Contributor

Vurv78 commented Nov 14, 2023

Workflow isn't properly configured, missing the changed-files step: https://github.com/wiremod/wire/blob/master/.github/workflows/lint.yml

@thegrb93 thegrb93 merged commit 9a16f24 into wiremod:master Nov 15, 2023
1 check failed
@DerelictDrone DerelictDrone deleted the editor-warnings branch November 18, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants