Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve UI of in call emoji reactions (WPB-14622) #18559

Merged
merged 1 commit into from
Jan 7, 2025
Merged

feat: Improve UI of in call emoji reactions (WPB-14622) #18559

merged 1 commit into from
Jan 7, 2025

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Jan 6, 2025 •
edited by github-actions bot
Loading

StoryWPB-14622 UI Improvements of in-call reactions

Description

  • adjusted size, text/emoji proportions + placement
  • adjusted speed and animation

@thisisamir98 thisisamir98 requested review from otto-the-bot and a team as code owners January 6, 2025 16:54
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.22%. Comparing base (c5aa35d) to head (348f94f).
Report is 10 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #18559      +/-   ##
==========================================
+ Coverage   46.20%   46.22%   +0.02%     
==========================================
  Files         868      868              
  Lines       26711    26711              
  Branches     6043     6043              
==========================================
+ Hits        12342    12348       +6     
+ Misses      12829    12825       -4     
+ Partials     1540     1538       -2

@thisisamir98 thisisamir98 merged commit b6dd427 into dev Jan 7, 2025
15 of 16 checks passed
@thisisamir98 thisisamir98 deleted the WPB-14622 branch January 7, 2025 08:33
@paulwire paulwire added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafsulich olafsulich olafsulich approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: S type: feature / request ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thisisamir98 @codecov-commenter @olafsulich @otto-the-bot @paulwire