Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: press space to unmute #18544

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: press space to unmute #18544

merged 2 commits into from
Dec 20, 2024

Conversation

olafsulich
Copy link
Contributor

Description

  • fixed app notification doesn't show sometimes (quite randomly, increasing the delay should work)
  • does not mute when pressing space

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.23%. Comparing base (1a8532e) to head (a687c38).
Report is 10 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18544      +/-   ##
==========================================
+ Coverage   46.18%   46.23%   +0.04%     
==========================================
  Files         868      868              
  Lines       26707    26707              
  Branches     6043     6043              
==========================================
+ Hits        12335    12347      +12     
+ Misses      12831    12821      -10     
+ Partials     1541     1539       -2     

@olafsulich olafsulich merged commit 0ff79f1 into dev Dec 20, 2024
15 of 16 checks passed
@olafsulich olafsulich deleted the fix/press-space-to-unmute branch December 20, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants