Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not show notification when call feedback is skipped #18540

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: Do not show notification when call feedback is skipped #18540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efc6e22
fix: Do not show notification when call feedback is skipped
thisisamir98 Dec 19, 2024
4bdc579
use object
thisisamir98 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/script/components/Modals/QualityFeedbackModal/QualityFeedbackModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const QualityFeedbackModal = () => {
return null;
}

const handleCloseModal = () => {
const handleCloseModal = ({skipNotification = false} = {}) => {
if (!selfUser) {
setQualityFeedbackModalShown(false);
return;
Expand All @@ -80,7 +80,10 @@ export const QualityFeedbackModal = () => {

currentStorageData[selfUser.id] = isChecked ? null : dateUntilShowModal.getTime();
localStorage.setItem(CALL_QUALITY_FEEDBACK_KEY, JSON.stringify(currentStorageData));
submittedNotification.show();

if (!skipNotification) {
submittedNotification.show();
}
} catch (error) {
logger.warn(`Can't send feedback: ${(error as Error).message}`);
} finally {
Expand All @@ -102,7 +105,7 @@ export const QualityFeedbackModal = () => {
[Segmentation.CALL.QUALITY_REVIEW_LABEL]: RatingListLabel.DISMISSED,
});

handleCloseModal();
handleCloseModal({skipNotification: true});
};

return (
Expand Down
2 changes: 1 addition & 1 deletion src/types/i18n.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1630,7 +1630,7 @@ declare module 'I18n/en-US.json' {
'videoCallOverlayViewModeSpeakers': `Show active speakers only`;
'videoCallParticipantConnecting': `Connecting...`;
'videoCallParticipantLowerYourHand': `Lower your hand`;
'videoCallParticipantPressSpaceToUnmuteNotification': `Microphone temporarily on`;
'videoCallParticipantPressSpaceToUnmuteNotification': `Your microphone is on`;
'videoCallParticipantRaiseYourHand': `Raise your hand`;
'videoCallParticipantRaisedHandRaiseDuration': `Hand raised for {duration}`;
'videoCallParticipantRaisedSelfHandUp': `You have raised your hand up`;
Expand Down
Loading