fix: dont show E2EI shield and correct ciphersuite [WPB-15023] [WPB-15025] #18489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18489 +/- ##
==========================================
- Coverage 46.29% 46.29% -0.01%
==========================================
Files 845 845
Lines 26423 26431 +8
Branches 5989 5994 +5
==========================================
+ Hits 12233 12236 +3
- Misses 12654 12662 +8
+ Partials 1536 1533 -3 |
|
V-Gira
reviewed
Dec 12, 2024
Comment on lines
+30
to
+36
| export const MLSPublicKeys = { | ||
| ed25519: 'ED25519', | ||
| ed448: 'ED448', | ||
| ecdsa_secp521r1_sha512: 'EDCSA_SECP521R1_SHA512', | ||
| ecdsa_secp384r1_sha384: 'EDCSA_SECP384R1_SHA384', | ||
| ecdsa_secp256r1_sha256: 'EDCSA_SECP256R1_SHA256', | ||
| } as const; |
There was a problem hiding this comment.
We don't align with iOS for those?
FYI we're using those strings in the conversation details with Cyphersuite[<number>] (enum from Core-Crypto)
V-Gira
approved these changes
Dec 13, 2024
V-Gira
pushed a commit
that referenced
this pull request
Dec 13, 2024
paulwire
added
the
echoes: product-roadmap/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix No1 https://wearezeta.atlassian.net/browse/WPB-15023
Bugfix No2 https://wearezeta.atlassian.net/browse/WPB-15025