Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix(api-client/core): use v7 endpoint for setting member conversation roles [WPB-15024] #18488

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Dec 12, 2024

TaskWPB-15024 [Web] Use proper v7 endpoint for making someone group admin

Description

The endpoint using a string as user id is deprecated in v7 and replaced by an endpoint that accepts QualifiedId only, see https://staging-nginz-https.zinfra.io/v4/api/swagger-ui/#/default/update-other-member

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.30%. Comparing base (6ad3f26) to head (7bae3cf).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #18488   +/-   ##
=======================================
  Coverage   46.29%   46.30%           
=======================================
  Files         845      845           
  Lines       26423    26425    +2     
  Branches     5989     5989           
=======================================
+ Hits        12233    12236    +3     
  Misses      12654    12654           
+ Partials     1536     1535    -1     

@V-Gira V-Gira merged commit 64fd75d into dev Dec 13, 2024
11 checks passed
@V-Gira V-Gira deleted the v/v7-add-admin branch December 13, 2024 11:04
V-Gira added a commit that referenced this pull request Dec 13, 2024
…ion roles [WPB-15024] (#18488)

* chore(deps): bump core to 46.15.0

* feat(api-client/core): use v7 endpoint for setting member conversation roles [WPB-15024]

* runfix: use conversation's qualified id

* chore(deps): bump core to 46.15.1

* chore(deps): bump core to 46.15.3
@paulwire paulwire added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants