Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Revert "chore: set default api to v7 (#18478)" #18483

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: Revert "chore: set default api to v7 (#18478)" #18483

merged 1 commit into from
Dec 11, 2024

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Dec 11, 2024

This reverts commit 66f6d07.

Description

This reverts commit 66f6d07.

We'll revert setting the default api version to v7 for the nightly run

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@V-Gira V-Gira requested review from otto-the-bot and a team as code owners December 11, 2024 17:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.32%. Comparing base (a77dc24) to head (120f81b).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #18483      +/-   ##
==========================================
- Coverage   46.34%   46.32%   -0.02%     
==========================================
  Files         846      846              
  Lines       26400    26400              
  Branches     5984     5984              
==========================================
- Hits        12234    12231       -3     
- Misses      12633    12636       +3     
  Partials     1533     1533

@V-Gira V-Gira merged commit 34383fc into dev Dec 11, 2024
11 checks passed
@V-Gira V-Gira deleted the v/revert-v7 branch December 11, 2024 17:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@paulwire paulwire added echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: unplanned Any work item that isn’t part of the product or technical roadmap. and removed echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. labels Dec 11, 2024
V-Gira added a commit that referenced this pull request Dec 12, 2024
@V-Gira
Chore: restore "chore: set default api to v7 (#18478)" (#18483)"
c7021e7 
This reverts commit 34383fc.
V-Gira added a commit that referenced this pull request Dec 12, 2024
@V-Gira
chore: restore default api v7 and MLS env variable removal (#18485)
ad9574f 
* Chore: restore "chore: set default api to v7 (#18478)" (#18483)"

This reverts commit 34383fc.

* chore: restore "feat: remove the environmental mls feature flag (#18479)" (#18484)"

This reverts commit d392567.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlebon tlebon tlebon approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 👕 size: XS type: chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@V-Gira @codecov-commenter @tlebon @otto-the-bot @paulwire