Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable zoom feature for screen share [WPB-14947] #18475

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

EnricoSchw
Copy link
Contributor

@EnricoSchw EnricoSchw commented Dec 11, 2024

TaskWPB-14947 [Web] Move zoom in on screenshare behind a feature flag until designs are done

Description

We are removing the screenshare zoom feature again

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.33%. Comparing base (888e5ac) to head (91e5945).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18475      +/-   ##
==========================================
+ Coverage   46.31%   46.33%   +0.01%     
==========================================
  Files         846      846              
  Lines       26408    26401       -7     
  Branches     5989     5984       -5     
==========================================
+ Hits        12231    12233       +2     
+ Misses      12643    12636       -7     
+ Partials     1534     1532       -2     

Copy link
Contributor

@e-maad e-maad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@EnricoSchw EnricoSchw merged commit d1a063c into dev Dec 11, 2024
13 checks passed
@EnricoSchw EnricoSchw deleted the feat/disable-zoom-WPB-14947 branch December 11, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants