Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): address copy review for group deletion [WPB-11558] #18471

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Dec 10, 2024

StoryWPB-11558 [Web] Remove a group from my conversation list after leaving it

Description

The localization team requested a change to the strings in the group deletion flow
see figma here

Screenshots/Screencast (for UI changes)

Screenshot From 2024-12-10 12-47-11

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.32%. Comparing base (4dac7ea) to head (ed406ac).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18471      +/-   ##
==========================================
- Coverage   46.33%   46.32%   -0.02%     
==========================================
  Files         846      846              
  Lines       26399    26399              
  Branches     5986     5986              
==========================================
- Hits        12233    12230       -3     
- Misses      12634    12637       +3     
  Partials     1532     1532              

@V-Gira V-Gira merged commit d907708 into dev Dec 10, 2024
11 checks passed
@V-Gira V-Gira deleted the v/delete-group-localization branch December 10, 2024 12:12
@paulwire paulwire added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants