feat: update backend configs regularly [WPB-14727] #18466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned/incident
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18466 +/- ##
==========================================
- Coverage 46.33% 46.33% -0.01%
==========================================
Files 845 846 +1
Lines 26379 26392 +13
Branches 5981 5983 +2
==========================================
+ Hits 12223 12229 +6
- Misses 12626 12634 +8
+ Partials 1530 1529 -1 |
|
e-maad
approved these changes
Dec 9, 2024
| @@ -77,8 +78,7 @@ const render = (Component: FC): void => { | |||
| const config = Config.getConfig(); | |||
|
|
|||
| async function runApp() { | |||
| const [min, max] = config.SUPPORTED_API_RANGE; | |||
| const {domain} = await core.useAPIVersion(min, max, config.ENABLE_DEV_BACKEND_API); | |||
| const {domain} = await updateApiVersion(); | |||
There was a problem hiding this comment.
Don't we need to schedule updateApiVersion job for auth app?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update following endpoints every 24h AND every "window-focus-event":