feat: Screen Share improvement for Group Calls [WPB-10134] #18445
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18445 +/- ##
==========================================
- Coverage 46.33% 46.31% -0.03%
==========================================
Files 846 846
Lines 26399 26408 +9
Branches 5986 5989 +3
==========================================
- Hits 12233 12231 -2
- Misses 12634 12643 +9
- Partials 1532 1534 +2 |
| const handleZoomClick = () => { | ||
| if (isZoomedIn) { | ||
| setIsZoomedIn(false); | ||
| } else { | ||
| setIsZoomedIn(true); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
| const handleZoomClick = () => { | |
| if (isZoomedIn) { | |
| setIsZoomedIn(false); | |
| } else { | |
| setIsZoomedIn(true); | |
| } | |
| }; | |
| const handleZoomClick = () => { | |
| setIsZoomedIn(prev => !prev); |
| onClick={handleZoomClick} | ||
| onKeyDown={handleZoomClick} |
There was a problem hiding this comment.
two are unnecessarily, only onClick should be enough
There was a problem hiding this comment.
You use both events in many places... I thought it was a workaround. I will remove it
| this.isConferenceCallingEnabled = ko.pureComputed( | ||
| () => this.teamFeatures()?.conferenceCalling?.status === FeatureStatus.ENABLED, | ||
| ); | ||
| this.isConferenceCallingEnabled = ko.pureComputed(() => true); |
There was a problem hiding this comment.
if it's gonna be always true I suggest a bigger refactor to just get rid of this property every where, but for now we could at least set it to an always true observable maybe
| this.isConferenceCallingEnabled = ko.pureComputed(() => true); | |
| this.isConferenceCallingEnabled = ko.observable(true); |
There was a problem hiding this comment.
O good finding.. ❤️ Thx. this is a hack to activate group call.. This should never go to staging. I will remove this!
|
Screen Share improvement for Group Calls
This is an improvement to the readability of screen sharing:
Screenshots/Screencast (for UI changes)
@WolfiWire
I think you'll have an opinion on this, but I'd like to adjust the zoom feature in a fallow up PR. I hope this is ok
(These PRs always take so long :) )
Checklist