Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: change import of useWarnings hook #18441

Merged
merged 1 commit into from
Dec 6, 2024
Merged

revert: change import of useWarnings hook #18441

merged 1 commit into from
Dec 6, 2024

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Dec 6, 2024

Reverts #18434

@przemvs przemvs requested review from otto-the-bot and a team as code owners December 6, 2024 10:40
@przemvs przemvs changed the title chore: change import of useWarnings hook chore: Revert change import of useWarnings hook Dec 6, 2024
@przemvs przemvs changed the title chore: Revert change import of useWarnings hook revert: change import of useWarnings hook Dec 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.35%. Comparing base (5f1e15e) to head (16eb3a5).
Report is 16 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #18441   +/-   ##
=======================================
  Coverage   46.35%   46.35%           
=======================================
  Files         846      846           
  Lines       26372    26372           
  Branches     5979     5979           
=======================================
+ Hits        12224    12225    +1     
+ Misses      12617    12616    -1     
  Partials     1531     1531

@przemvs przemvs force-pushed the revert-18434-fix/change-import-of-use-warnings-hook branch from c7734c0 to 16eb3a5 Compare December 6, 2024 10:47
@przemvs przemvs enabled auto-merge (squash) December 6, 2024 10:50
@przemvs przemvs merged commit 02854ae into dev Dec 6, 2024
11 checks passed
@przemvs przemvs deleted the revert-18434-fix/change-import-of-use-warnings-hook branch December 6, 2024 10:51
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@paulwire paulwire added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aweiss-dev aweiss-dev aweiss-dev approved these changes

@thisisamir98 thisisamir98 thisisamir98 approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. 👕 size: XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@przemvs @codecov-commenter @thisisamir98 @aweiss-dev @otto-the-bot @paulwire