fix: make zod errors not hard crash #18418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18418 +/- ##
==========================================
- Coverage 46.44% 46.44% -0.01%
==========================================
Files 844 844
Lines 26210 26216 +6
Branches 5936 5939 +3
==========================================
+ Hits 12174 12175 +1
- Misses 12513 12519 +6
+ Partials 1523 1522 -1 |
|
olafsulich
approved these changes
Dec 4, 2024
paulwire
added
the
echoes: product-roadmap/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zod implementation was very strict.
If there was some unexpected data, the CPB would not execute. This will change the behaviour to log the error.