-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-3307] #18389
Draft
dariaoldenburg
wants to merge
11
commits into
dev
Choose a base branch
from
feat/WPB-3307-calling-UI
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,714
−871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
label
Nov 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18389 +/- ##
==========================================
- Coverage 46.56% 46.56% -0.01%
==========================================
Files 828 835 +7
Lines 26030 26057 +27
Branches 5899 5915 +16
==========================================
+ Hits 12122 12134 +12
- Misses 12393 12405 +12
- Partials 1515 1518 +3 |
dariaoldenburg
force-pushed
the
feat/WPB-3307-calling-UI
branch
from
November 28, 2024 09:55
8bdea20
to
69f6b96
Compare
dariaoldenburg
changed the title
feat(pagination): update design and logic for pagination
feat(pagination): update design and logic for pagination [WPB-423]
Nov 28, 2024
dariaoldenburg
changed the title
feat(pagination): update design and logic for pagination [WPB-423]
feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-423]
Nov 28, 2024
dariaoldenburg
force-pushed
the
feat/WPB-3307-calling-UI
branch
from
December 19, 2024 17:40
97b5460
to
6be189d
Compare
dariaoldenburg
force-pushed
the
feat/WPB-3307-calling-UI
branch
2 times, most recently
from
December 30, 2024 22:24
fb6e2dc
to
f7ea84a
Compare
dariaoldenburg
changed the title
feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-423]
feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-3307]
Jan 7, 2025
dariaoldenburg
changed the title
feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-3307]
feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-330]
Jan 7, 2025
dariaoldenburg
changed the title
feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-330]
feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-3307]
Jan 7, 2025
dariaoldenburg
force-pushed
the
feat/WPB-3307-calling-UI
branch
from
January 7, 2025 22:37
f7ea84a
to
1b684dc
Compare
…o Pagination component and adjust layout for fullscreenVideoCall component
dariaoldenburg
force-pushed
the
feat/WPB-3307-calling-UI
branch
from
January 15, 2025 23:25
1b684dc
to
5df61b0
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
👕 size: M
type: feature / request ✨
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will change a few functionalities and styles, so I recommend reviewing it commit by commit. Of course, feel free to review it however you prefer :)
What I did in this PR:
On mobile resolutions, pagination is aligned to the bottom.
Added a "More" menu button (I used ContextMenu for that, as per the designer’s decision). I also updated the styles for ContextMenu to match the Figma design. There’s still some work to be done here, but I created a separate task for it.
What I didn’t do in this PR:
New tasks I created after working on this PR:
Checklist