Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-3307] #18389

Draft
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

dariaoldenburg
Copy link
Contributor

@dariaoldenburg dariaoldenburg commented Nov 26, 2024

StoryWPB-3307 Make the calling UI react to narrow screen sizes

Description

This PR will change a few functionalities and styles, so I recommend reviewing it commit by commit. Of course, feel free to review it however you prefer :)

What I did in this PR:

  • Updated the design and logic for pagination.
    On mobile resolutions, pagination is aligned to the bottom.
  • Made the layout responsive for the video top bar, ensuring spacings match the Figma design.
  • Made the video grid responsive, with multiple breakpoints (both horizontally and vertically).
  • Made the video controls responsive:
    Added a "More" menu button (I used ContextMenu for that, as per the designer’s decision). I also updated the styles for ContextMenu to match the Figma design. There’s still some work to be done here, but I created a separate task for it.
  • Some minor refactoring, splitting into smaller components, and standardizing the styling approach.

What I didn’t do in this PR:

  • The See participants button on mobile should open the same way as video settings, audio settings, and view mode (it currently looks like a select dropdown, but we can’t use the Select component since it isn’t a true Select). —> TODO task

New tasks I created after working on this PR:

Checklist

  • mentions the JIRA issue in the PR name (Ex. WPB-3307)
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 46.56%. Comparing base (3963a76) to head (69f6b96).
Report is 75 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18389      +/-   ##
==========================================
- Coverage   46.56%   46.56%   -0.01%     
==========================================
  Files         828      835       +7     
  Lines       26030    26057      +27     
  Branches     5899     5915      +16     
==========================================
+ Hits        12122    12134      +12     
- Misses      12393    12405      +12     
- Partials     1515     1518       +3     

@dariaoldenburg dariaoldenburg force-pushed the feat/WPB-3307-calling-UI branch from 8bdea20 to 69f6b96 Compare November 28, 2024 09:55
@dariaoldenburg dariaoldenburg changed the title feat(pagination): update design and logic for pagination feat(pagination): update design and logic for pagination [WPB-423] Nov 28, 2024
@dariaoldenburg dariaoldenburg changed the title feat(pagination): update design and logic for pagination [WPB-423] feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-423] Nov 28, 2024
@dariaoldenburg dariaoldenburg force-pushed the feat/WPB-3307-calling-UI branch from 97b5460 to 6be189d Compare December 19, 2024 17:40
@dariaoldenburg dariaoldenburg force-pushed the feat/WPB-3307-calling-UI branch 2 times, most recently from fb6e2dc to f7ea84a Compare December 30, 2024 22:24
@dariaoldenburg dariaoldenburg changed the title feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-423] feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-3307] Jan 7, 2025
@dariaoldenburg dariaoldenburg changed the title feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-3307] feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-330] Jan 7, 2025
@dariaoldenburg dariaoldenburg changed the title feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-330] feat(pagination&&grid): update design and logic for pagination and layout for grid [WPB-3307] Jan 7, 2025
@dariaoldenburg dariaoldenburg force-pushed the feat/WPB-3307-calling-UI branch from f7ea84a to 1b684dc Compare January 7, 2025 22:37
@dariaoldenburg dariaoldenburg force-pushed the feat/WPB-3307-calling-UI branch from 1b684dc to 5df61b0 Compare January 15, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 👕 size: M type: feature / request ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants