feat: Improve event builder #17756
Draft
feat: Improve event builder #17756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tlebon
reviewed
Jul 16, 2024
Comment on lines
+972
to
+974
| // const creationEvent = conversationEntity.isGroup() | ||
| // ? EventBuilder.buildGroupCreation(conversationEntity, isTemporaryGuest, timestamp) | ||
| // : EventBuilder.build1to1Creation(conversationEntity); |
tlebon
reviewed
Jul 16, 2024
| @@ -2304,7 +2347,12 @@ export class ConversationRepository { | |||
| }) => { | |||
| switch (conversationVerificationState) { | |||
| case ConversationVerificationState.VERIFIED: | |||
| const allVerifiedEvent = EventBuilder.buildAllVerified(conversationEntity); | |||
| // const allVerifiedEvent = EventBuilder.buildAllVerified(conversationEntity); | |||
tlebon
reviewed
Jul 16, 2024
| @@ -135,7 +135,7 @@ describe('ProteusConversationVerificationStateHandler', () => { | |||
| expect(conversationB.verification_state()).toBe(ConversationVerificationState.VERIFIED); | |||
| expect(conversationAB.is_verified()).toBeDefined(); | |||
| expect(conversationAB.is_verified()).toBeTruthy(); | |||
| expect(EventBuilder.buildAllVerified).not.toHaveBeenCalled(); | |||
| // expect(EventBuilder.buildAllVerified).not.toHaveBeenCalled(); | |||
There was a problem hiding this comment.
guess this should be replaced with createBaseEvent
tlebon
reviewed
Jul 16, 2024
| @@ -169,7 +169,7 @@ describe('ProteusConversationVerificationStateHandler', () => { | |||
| expect(conversationAB.verification_state()).toBe(ConversationVerificationState.VERIFIED); | |||
| expect(conversationB.verification_state()).toBe(ConversationVerificationState.VERIFIED); | |||
| expect(conversationC.verification_state()).toBe(ConversationVerificationState.VERIFIED); | |||
| expect(EventBuilder.buildAllVerified).toHaveBeenCalledTimes(3); | |||
| // expect(EventBuilder.buildAllVerified).toHaveBeenCalledTimes(3); | |||
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)