feat: view port observer on lost visibility #17417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #17417 +/- ##
==========================================
- Coverage 46.15% 46.14% -0.01%
==========================================
Files 753 753
Lines 24732 24737 +5
Branches 5671 5672 +1
==========================================
+ Hits 11414 11416 +2
- Misses 11886 11887 +1
- Partials 1432 1434 +2 |
PatrykBuniX
commented
May 20, 2024
Comment on lines
+64
to
+66
| if (!onVisibilityLost) { | ||
| releaseTrackers(); | ||
| } |
There was a problem hiding this comment.
We don't want to release the trackers after detecting element's visibility (we want to detect its visibility lost later).
PatrykBuniX
commented
May 20, 2024
Comment on lines
+21
to
+26
| Element, | ||
| { | ||
| allowBiggerThanViewport?: boolean; | ||
| requireFullyInView?: boolean; | ||
| onVisible?: Function; | ||
| onVisibilityChange?: (isVisible: boolean, isPartiallyVisible: boolean) => void; |
There was a problem hiding this comment.
Just added types here and renamed onChange to onVisibilityChange for more clarity.
przemvs
approved these changes
May 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an ability to subscribe to visibility loss after the changing the visibility from "visible", to "not visible at all" (not intersecting at all).
Checklist