Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align setting header to the left (WPB-8832) #17410

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: align setting header to the left (WPB-8832) #17410

merged 1 commit into from
May 15, 2024

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented May 15, 2024 •
edited by github-actions bot
Loading

BugWPB-8832 Text alignment and background color still wrong in Settings view

Description

The new navigation's design has the header in the middle sidebar left aligned instead of centered

Screenshots/Screencast (for UI changes)

Before:
image

After:
image

@V-Gira V-Gira requested review from otto-the-bot and a team as code owners May 15, 2024 15:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@V-Gira V-Gira merged commit 44ea28e into new-navigation May 15, 2024
10 checks passed
@V-Gira V-Gira deleted the v/setting-header branch May 15, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aweiss-dev aweiss-dev aweiss-dev approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot

Assignees
No one assigned
Labels
👕 size: S type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@V-Gira @aweiss-dev @otto-the-bot