runfix: adress responsivness of the preferences sections (WPB-7214) #17409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
V-Gira
commented
May 15, 2024
Comment on lines
-55
to
-57
| input { | ||
| color: var(--background); | ||
| } |
There was a problem hiding this comment.
This appears to be a years old leftover that we can remove
V-Gira
commented
May 15, 2024
| overflowX: 'hidden', | ||
|
|
||
| // Rely on viewport media queries if container queries are not supported by the browser | ||
| '@media (max-width: 768px)': { |
There was a problem hiding this comment.
css variables are not supported in media queries and less variables don't work outside of less files unfortunately
PatrykBuniX
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can use container queries to have the content of the preference pages be responsive with its container instead of the viewport.
Standard media queries are used as a fallback.
This allows the preferences page to be responvive regardless of the state of the new sidebar
Screenshots/Screencast (for UI changes)
Before: (layout breaks just before going into responsive design with the sidebar opened)
After: