Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: do not overwrite service id when opening the service details #17405

Merged
merged 4 commits into from
May 14, 2024

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented May 14, 2024

Description

After fixing a different bug (see https://github.com/wireapp/wire-webapp/pull/17378/files#diff-42332a315c252fd2b9da98fb360d34d231ad1fd02b62c115ee191dfd6dc86fa1R236), there was an oversight and I've forgot to update another place where are opening the right conversation panel with service entity.

We should not overwrite the service entity id with user's id when opening a right sidebar panel. It needs a service id (the one set on backend) to work properly.

Also the isAddMode was moved to the right panel opening params. When it was kept inside the react state (and right panel was not closed before opening again with the avatar click), the add button was visible even though the service was already added.

Screenshots/Screencast (for UI changes)

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.08%. Comparing base (5b8ae94) to head (46fdc78).

❗ Current head 46fdc78 differs from pull request most recent head adf569b. Consider uploading reports for the commit adf569b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #17405   +/-   ##
=======================================
  Coverage   46.08%   46.08%           
=======================================
  Files         753      753           
  Lines       24728    24728           
  Branches     5668     5668           
=======================================
+ Hits        11395    11396    +1     
  Misses      11903    11903           
+ Partials     1430     1429    -1     

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@przemvs przemvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@PatrykBuniX PatrykBuniX merged commit 1a4edcb into dev May 14, 2024
11 checks passed
@PatrykBuniX PatrykBuniX deleted the runfix/bot-user-settings branch May 14, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants