Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve conversation error reports #16556

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Jan 18, 2024

Description

Before

image

After

image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;


this.type = type;
this.message = message;
this.stack = new Error().stack;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewritting the stack was the problem here. We were adding one more element on top of the stack which prevented the browser from showing correctly the error message

@atomrc atomrc enabled auto-merge (squash) January 18, 2024 17:22
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fce6cd7) 45.42% compared to head (52d5e13) 45.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16556      +/-   ##
==========================================
- Coverage   45.42%   45.42%   -0.01%     
==========================================
  Files         740      740              
  Lines       24241    24239       -2     
  Branches     5506     5506              
==========================================
- Hits        11012    11010       -2     
  Misses      11822    11822              
  Partials     1407     1407              

@atomrc atomrc merged commit f20d2bb into dev Jan 18, 2024
16 checks passed
@atomrc atomrc deleted the runfix/improve-errors branch January 18, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants