Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Single source of truth to know if e2ei should be enabled #16552

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Jan 18, 2024

Description

We are currently looking at both the FEATURE.ENABLE_E2EI feature flag and the team setting config to know if we should start the e2ei process.
The way we check for e2ei enable state is not consistent accros the app.

This PR harmonizes the source of truth whether the e2ei feature is enabled or not. it's E2EIHandler.getInstance().isE2EIEnabled() method.

Before (in a e2ei disabled team)

image

After

image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@atomrc atomrc merged commit 1008e61 into dev Jan 18, 2024
9 checks passed
@atomrc atomrc deleted the runfix/e2ei-feature-flag branch January 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants