feat: update message for enrolment, renewal, error modal when grace period is over #16551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16551 +/- ##
==========================================
- Coverage 45.43% 45.42% -0.01%
==========================================
Files 740 740
Lines 24239 24243 +4
Branches 5506 5509 +3
==========================================
Hits 11012 11012
- Misses 11818 11821 +3
- Partials 1409 1410 +1 |
atomrc
reviewed
Jan 18, 2024
| @@ -365,13 +365,13 @@ export class E2EIHandler extends TypedEventEmitter<Events> { | |||
| // Clear the e2e identity progress | |||
| this.coreE2EIService.clearAllProgress(); | |||
|
|
|||
| const isSoftLockEnabled = await shouldEnableSoftLock(this.config!); | |||
| const disableSnooze = await shouldEnableSoftLock(this.config!); | |||
atomrc
reviewed
Jan 18, 2024
Comment on lines
36
to
49
| /** | ||
| * Options for configuring a modal. | ||
| * @typedef {Object} GetModalOptions | ||
| * @property {ModalType} type - The type of modal to display. | ||
| * @property {Function} [primaryActionFn] - Function to execute for the primary action. | ||
| * @property {Function} [secondaryActionFn] - Function to execute for the secondary action. | ||
| * @property {boolean} [hideSecondary=false] - Flag to hide the secondary action button. | ||
| * @property {boolean} [hidePrimary=false] - Flag to hide the primary action button. | ||
| * @property {boolean} [hideClose=false] - Flag to hide the close button. | ||
| * @property {Object} [extraParams] - Additional parameters for the modal. | ||
| * @property {string} [extraParams.delayTime] - time left to remind the user again for enroll/renewal. | ||
| * @property {boolean} [extraParams.isRenewal] - Flag indicating if this is a renewal action. | ||
| * @property {boolean} [extraParams.isGracePeriodOver] - Flag indicating if the grace period is over. | ||
| */ |
There was a problem hiding this comment.
Oh, you did it the hard way. There is actually a super nice jsdoc/typescript feature where you can inline jsdoc directly in the types. I'll show you in a diff comment
There was a problem hiding this comment.
Ahh ok, shall i remove my jsdoc then?
There was a problem hiding this comment.
I think you can remove them then :)
Inline jsdoc has the benefit of showing up on the typescript server language :)
atomrc
reviewed
Jan 18, 2024
atomrc
approved these changes
Jan 18, 2024
Co-authored-by: Thomas Belin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update message for enrolment, renewal, error modal when grace period is over
Screenshots/Screencast (for UI changes)