refactor: Cleanup the enrollment snooze feature #16544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Jan 18, 2024
Comment on lines
-399
to
-409
| if (this.currentStep === E2EIHandlerStep.UNINITIALIZED) { | ||
| this.config?.timer.updateParams({ | ||
| gracePeriodInMS: this.config.gracePeriodInMs, | ||
| gracePeriodExpiredCallback: () => { | ||
| this.showE2EINotificationMessage(ModalType.ENROLL); | ||
| }, | ||
| delayPeriodExpiredCallback: () => { | ||
| this.showE2EINotificationMessage(ModalType.ENROLL); | ||
| }, | ||
| }); | ||
| this.currentStep = E2EIHandlerStep.INITIALIZED; |
There was a problem hiding this comment.
This is now set in the initialize method
PatrykBuniX
approved these changes
Jan 18, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16544 +/- ##
==========================================
- Coverage 45.44% 45.42% -0.02%
==========================================
Files 740 740
Lines 24239 24241 +2
Branches 5507 5507
==========================================
- Hits 11015 11012 -3
- Misses 11813 11819 +6
+ Partials 1411 1410 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will harmonize the naming of the
snoozefeature accros the codebase. It was previously calleddelaybut did not convey the correct idea.We decided to name it
snoozeeverywhereChecklist