refactor: streamline softLock logic #16536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Jan 17, 2024
Comment on lines
-62
to
-76
| useEffect(() => { | ||
| if (e2eiEnabled) { | ||
| void checkIfIsFreshMLSSelfClient(); | ||
| } | ||
| }, [e2eiEnabled]); | ||
|
|
||
| useEffect(() => { | ||
| if (!freshMLSSelfClient) { | ||
| return () => {}; | ||
| } | ||
| E2EIHandler.getInstance().on('enrollmentSuccessful', checkIfIsFreshMLSSelfClient); | ||
| return () => { | ||
| E2EIHandler.getInstance().off('enrollmentSuccessful', checkIfIsFreshMLSSelfClient); | ||
| }; | ||
| }, [freshMLSSelfClient]); |
There was a problem hiding this comment.
This logic has been factored in the handling of the identityUpdate event
przemvs
approved these changes
Jan 17, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16536 +/- ##
==========================================
- Coverage 45.42% 45.38% -0.04%
==========================================
Files 740 740
Lines 24218 24258 +40
Branches 5504 5518 +14
==========================================
+ Hits 11000 11009 +9
- Misses 11806 11829 +23
- Partials 1412 1420 +8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This harmonises the way we compute if we should enable soft lock or not.
This changes the following parts:
enrollmentSuccessandidentityUpateevents to be a single event that always sends theconfigandidentityChecklist