Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Message content width #16533

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Jan 16, 2024

Description

Changed message content width for 100%, also assets has max-width for 800px;

Screenshots/Screencast (for UI changes)

image

image

image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

Copy link
Contributor

@V-Gira V-Gira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye --conversation-message-timestamp-width, you won't be missed 👋

@atomrc
Copy link
Contributor

atomrc commented Jan 17, 2024

@przemvs let's not merge now (let's wait for the zulu code-freeze) if you don't mind

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (eb572d2) 45.42% compared to head (b8f359d) 45.39%.
Report is 20 commits behind head on release/q1-2024.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/q1-2024   #16533      +/-   ##
===================================================
- Coverage            45.42%   45.39%   -0.03%     
===================================================
  Files                  740      742       +2     
  Lines                24239    24278      +39     
  Branches              5506     5524      +18     
===================================================
+ Hits                 11010    11022      +12     
- Misses               11822    11846      +24     
- Partials              1407     1410       +3     

* feat: Group messages in the chat by user and timestamp

* feat: Prepare new version

* improve message asset read indicator

* revert opacity to 0 for not hovered message

* revert expectsReadConfirmation

* clear unecessary styles
@przemvs przemvs changed the base branch from dev to release/q1-2024 January 22, 2024 09:20
@przemvs przemvs merged commit 595d7a0 into release/q1-2024 Jan 22, 2024
12 checks passed
@przemvs przemvs deleted the feat/WPB-5852-message-content-width branch January 22, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants