Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: do not open a conversation with blocked user #16530

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

PatrykBuniX
Copy link
Contributor

Description

We should not allow to open a 1:1 conversation with a user we've blocked. This was only possible when navigating with a direct link by conversation id. We should display an error modal instead.

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c97e044) 45.48% compared to head (eb97aca) 45.42%.
Report is 39 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16530      +/-   ##
==========================================
- Coverage   45.48%   45.42%   -0.06%     
==========================================
  Files         739      740       +1     
  Lines       24182    24247      +65     
  Branches     5498     5509      +11     
==========================================
+ Hits        10999    11015      +16     
- Misses      11772    11821      +49     
  Partials     1411     1411              

@PatrykBuniX PatrykBuniX marked this pull request as ready for review January 18, 2024 08:58
@PatrykBuniX PatrykBuniX requested review from otto-the-bot and a team as code owners January 18, 2024 08:58
@PatrykBuniX PatrykBuniX merged commit 44f27ab into dev Jan 18, 2024
10 checks passed
@PatrykBuniX PatrykBuniX deleted the runfix/do-not-open-blocked-1to1 branch January 18, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants