runfix: stop counting e2ei system messages as unread [WPB-6081] #16503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16503 +/- ##
=======================================
Coverage 45.47% 45.48%
=======================================
Files 739 739
Lines 24177 24182 +5
Branches 5499 5498 -1
=======================================
+ Hits 10995 10998 +3
- Misses 11771 11772 +1
- Partials 1411 1412 +1 |
atomrc
reviewed
Jan 10, 2024
| @@ -72,7 +71,7 @@ interface UnreadState { | |||
| pings: PingMessage[]; | |||
| selfMentions: ContentMessage[]; | |||
| selfReplies: ContentMessage[]; | |||
| systemMessages: SystemMessage[]; | |||
There was a problem hiding this comment.
humm this is probably a mistake. The E2EIVerificationMessage should be a SystemMessage. Maybe this is the only change needed here 🤔
atomrc
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't want to include e2ei verification system messages in unread messages count.
Checklist