Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add snoozed reminder popup flow, enable soft lock when required #16419

Merged
merged 23 commits into from
Jan 16, 2024

Conversation

arjita-mitra
Copy link
Contributor

@arjita-mitra arjita-mitra commented Dec 22, 2023

Description

Show this popup when user performs either of these actions

  1. Remind me later to Get Certificate
  2. Cancel something went wrong error popup

Screenshots/Screencast (for UI changes)

Screenshot 2023-12-22 at 15 47 36

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

@arjita-mitra arjita-mitra requested review from otto-the-bot and a team as code owners December 22, 2023 15:14
@arjita-mitra arjita-mitra changed the title Improvements/certificate renewal feat: add snoozed reminder popup flow Dec 22, 2023
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 136 lines in your changes are missing coverage. Please review.

Comparison is base (1101f43) 45.43% compared to head (12af0dc) 45.37%.
Report is 56 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16419      +/-   ##
==========================================
- Coverage   45.43%   45.37%   -0.06%     
==========================================
  Files         740      740              
  Lines       24212    24273      +61     
  Branches     5502     5520      +18     
==========================================
+ Hits        11000    11015      +15     
- Misses      11800    11838      +38     
- Partials     1412     1420       +8     

@arjita-mitra arjita-mitra changed the title feat: add snoozed reminder popup flow feat: add snoozed reminder popup flow, enable soft lock when required Jan 15, 2024
Comment on lines +61 to +65
<div style="margin-bottom: 24px;">
<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64" viewBox="0 0 64 64" fill="none">
<path fill-rule="evenodd" clip-rule="evenodd" d="M60 32V7.48786L32 0L4 8V32C4 48 16.0287 60.3908 32 64C48.1374 60.3908 60 48 60 32ZM52 21.3829L27.4086 48L12 31.3842L16.9238 26.0013L27.4086 37.2342L47.0762 16L52 21.3829Z" fill="#1D7833"/>
</svg>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm what is this svg? Don't we have this in our icon library already? Feels a little weird to be hardcoded here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the green shield. I have found MLSVerified component in web-packages being used. My SVG isn't exactly same though. The height and width is also hard coded in the ui-kit MLSVerified component.

import {SVGIcon, SVGIconProps} from './SVGIcon';


export const MLSVerified = (props: SVGIconProps) => (
  <SVGIcon realWidth={16} realHeight={16} {...props}>
    <path
      fillRule="evenodd"
      clipRule="evenodd"
      d="M15 8V1.87197L8 0L1 2V8C1 12 4.00718 15.0977 8 16C12.0344 15.0977 15 12 15 8ZM13 5.34572L6.85214 12L3 7.84605L4.23094 6.50033L6.85214 9.30856L11.7691 4L13 5.34572Z"
      fill="#1D7833"
    />
  </SVGIcon>
);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-16 at 16 33 54

@arjita-mitra arjita-mitra merged commit f02fa35 into dev Jan 16, 2024
10 checks passed
@arjita-mitra arjita-mitra deleted the improvements/certificate-renewal branch January 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants