Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: prevent user from setting invalid supported protocols list #16217

Closed
wants to merge 3 commits into from

Conversation

PatrykBuniX
Copy link
Contributor

Description

Makes sure a web client do not update the list of self user's protocols list to an empty list. This is simple core bump, all the logic lives in core's services. For more details see wireapp/wire-web-packages#5716

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3c1fc5f) 45.51% compared to head (8d5d405) 45.23%.

❗ Current head 8d5d405 differs from pull request most recent head d32e933. Consider uploading reports for the commit d32e933 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16217      +/-   ##
==========================================
- Coverage   45.51%   45.23%   -0.29%     
==========================================
  Files         735      708      -27     
  Lines       24058    23365     -693     
  Branches     5473     5341     -132     
==========================================
- Hits        10950    10568     -382     
+ Misses      11704    11436     -268     
+ Partials     1404     1361      -43     

@PatrykBuniX PatrykBuniX force-pushed the runfix/other-user-supported-protocols branch from 8d5d405 to f42772b Compare January 2, 2024 10:40
@PatrykBuniX
Copy link
Contributor Author

Closing in favour of #16455

@PatrykBuniX PatrykBuniX closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants