runfix: problem with existing database entries #16020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2a7480c.
Codecov Report
@@ Coverage Diff @@
## dev #16020 +/- ##
=======================================
Coverage 44.78% 44.79%
=======================================
Files 701 701
Lines 23300 23302 +2
Branches 5291 5291
=======================================
+ Hits 10435 10437 +2
- Misses 11504 11505 +1
+ Partials 1361 1360 -1 |
atomrc
changed the title
atomrc
reviewed
Oct 17, 2023
| @@ -370,7 +369,7 @@ describe('ConversationMapper', () => { | |||
| status: 0, | |||
| team_id: teamId, | |||
| type: 0, | |||
| verification_state: ConversationVerificationState.UNVERIFIED, | |||
There was a problem hiding this comment.
I believe this was a nice change, why removing it? 🤔
atomrc
reviewed
Oct 17, 2023
| @@ -61,7 +60,7 @@ export interface SelfStatusUpdateDatabaseData { | |||
| otr_muted_status: number; | |||
| receipt_mode: number; | |||
| status: number; | |||
| verification_state: ConversationVerificationState; | |||
| verification_state: number; | |||
There was a problem hiding this comment.
This was also a valid change
aweiss-dev
deleted the
revert-16017-runfix/missing_degredation_warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16017