runfix: creation message not visible after accepting a connection

[PatrykBuniX]

Description

Problem

This PR #15935 fixed an issue with sending a connection from one device when the other is online, but it also introduced new issue: Every time after connection event was received (with any status) we were mapping a connection to a conversation what appeared to happen to frequently.

When accepting a connection request, we're mapping a connection to a conversation, right after that we're displaying this conversation, see: https://github.com/wireapp/wire-webapp/blob/runfix/connection-accept-empty-conversation/src/script/components/ConnectRequests/ConnectionRequests.tsx#L93.

The problem is that .acceptConnectionRequest triggers connection mapping logic (via amplify), and before conversation is created and saved in a local state, we call .getOrCreate1to1Conversation again, creating a new conversation entity. Member message was loaded to the conversation entity that was not opened in the end, causing an empty conversation to be visible.

Solution

The solution is to simply reduce the cases when connection is being mapped to a conversation. We map a connection only when connection request is sent (to maintain the fix for a bug described above), or was previously sent and now is accepted (old behaviour).

Screenshots/Screencast (for UI changes)

Checklist

• PR has been self reviewed by the author;
• Hard-to-understand areas of the code have been commented;
• If it is a core feature, unit tests have been added;

[codecov]

Codecov Report

Merging #15987 (0fda8f1) into dev (e58060b) will increase coverage by 0.01%.
Report is 4 commits behind head on dev.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev   #15987      +/-   ##
==========================================
+ Coverage   44.58%   44.60%   +0.01%     
==========================================
  Files         685      686       +1     
  Lines       22902    22911       +9     
  Branches     5201     5202       +1     
==========================================
+ Hits        10212    10220       +8     
- Misses      11373    11378       +5     
+ Partials     1317     1313       -4