Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: Avoid sending typing stop when user has not typed at all #15985

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Oct 12, 2023

Description

We need to keep track of whether the user has typed or not in a conversation to avoid sending too many typing stop events.
This will also prevent sending typing stop messages to conversation that do not exist anymore.

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@atomrc atomrc enabled auto-merge (squash) October 12, 2023 07:31
@atomrc atomrc merged commit 3f8fbd1 into dev Oct 12, 2023
@atomrc atomrc deleted the fix/typing-blocked-conv branch October 12, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants