refactor: Move MemberMessage rendering to UI component #15980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Oct 11, 2023
Comment on lines
-76
to
-81
| const handleShowMoreClick = (event: React.MouseEvent<HTMLElement, MouseEvent>) => { | ||
| const clickedOnShowMore = (event.target as HTMLElement).closest('.message-header-show-more'); | ||
| if (clickedOnShowMore) { | ||
| onClickParticipants(highlightedUsers); | ||
| } | ||
| }; |
There was a problem hiding this comment.
This is now a native React click handler (no more listening to clicks on the parent component)
atomrc
commented
Oct 11, 2023
| return <p className="message-header-caption" dangerouslySetInnerHTML={{__html: htmlCaption}}></p>; | ||
| export function MessageContent({message, onClickAction}: {message: MemberMessageEntity; onClickAction: () => void}) { | ||
| const htmlCaption = getContent(message); | ||
| const content = replaceReactComponents(htmlCaption, [ |
There was a problem hiding this comment.
This is where the magic happens. We input a string like "hello <strong>felix</strong>" and, with the right config, the <strong> part will be replace with a react component.
atomrc
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #15980 +/- ##
==========================================
+ Coverage 44.58% 44.60% +0.01%
==========================================
Files 685 686 +1
Lines 22902 22908 +6
Branches 5201 5201
==========================================
+ Hits 10212 10218 +6
- Misses 11373 11375 +2
+ Partials 1317 1315 -2 |
aweiss-dev
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the need to use
dangerouslySetInnerHTMLfor member system message rendered in the message list.Instead we do inline replacement of dynamic values in translations using the new
ReactLocalizerUtilScreenshots/Screencast (for UI changes)
Screen.Recording.2023-10-11.at.16.33.23.mov
Checklist