test: Add tests to member message rendering #15969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #15969 +/- ##
==========================================
+ Coverage 44.29% 44.48% +0.19%
==========================================
Files 684 685 +1
Lines 22905 22899 -6
Branches 5204 5201 -3
==========================================
+ Hits 10146 10187 +41
+ Misses 11457 11398 -59
- Partials 1302 1314 +12 |
atomrc
commented
Oct 11, 2023
Comment on lines
+20
to
+26
| import {MemberMessage as MemberMessageEntity} from 'src/script/entity/message/MemberMessage'; | ||
| import {useKoSubscribableChildren} from 'Util/ComponentUtil'; | ||
|
|
||
| export function MessageContent({message}: {message: MemberMessageEntity}) { | ||
| const {htmlCaption} = useKoSubscribableChildren(message, ['htmlCaption']); | ||
| return <p className="message-header-caption" dangerouslySetInnerHTML={{__html: htmlCaption}}></p>; | ||
| } |
There was a problem hiding this comment.
In a follow up PR, this will be where the rendering will be done (no more dangerouslySetInnerHTML in there)
atomrc
commented
Oct 11, 2023
Comment on lines
-137
to
-151
| case SystemMessageType.CONNECTION_ACCEPTED: | ||
| case SystemMessageType.CONNECTION_REQUEST: { | ||
| if (this.otherUser()) { | ||
| if (this.otherUser().isBlocked()) { | ||
| return t('conversationConnectionBlocked'); | ||
| } | ||
|
|
||
| if (this.otherUser().isOutgoingRequest()) { | ||
| return ''; | ||
| } | ||
| } | ||
|
|
||
| return t('conversationConnectionAccepted'); | ||
| } | ||
|
|
There was a problem hiding this comment.
This was never reachable
atomrc
commented
Oct 11, 2023
Comment on lines
-289
to
-292
| readonly showLargeAvatar = (): boolean => { | ||
| const largeAvatarTypes = [SystemMessageType.CONNECTION_ACCEPTED, SystemMessageType.CONNECTION_REQUEST]; | ||
| return largeAvatarTypes.includes(this.memberMessageType); | ||
| }; |
There was a problem hiding this comment.
Has been moved to the UI component (this doesn't belong here)
atomrc
changed the title
otto-the-bot
added
type: test 👷
👕 size: XL
and removed
type: refactoring 🛠
👕 size: L
labels
atomrc
force-pushed
the
refactor/member-message-render
branch
from
176f78c to
ebf7d79
Compare
PatrykBuniX
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparation for a refactoring of the
MemberMessageui component. The idea is to remove thedangerouslySetInnerHTMLand have the rendering done inreactdirectly.This covers the feature by test so that I'm sure I'm not going to break things when refactoring
Checklist