Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runfix: Only create a single system message for federation user removal #15967

Merged
merged 2 commits into from
Oct 11, 2023
Merged

runfix: Only create a single system message for federation user removal #15967

merged 2 commits into from
Oct 11, 2023

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Oct 10, 2023 •
edited
Loading

Description

This will inject a single system message when multiple users have been removed because of a de-federation event.

Screenshots/Screencast (for UI changes)

After

image

Before

image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@atomrc atomrc requested review from otto-the-bot and a team as code owners October 10, 2023 15:50
Base automatically changed from refactor/remove-members to dev October 11, 2023 07:13
@atomrc atomrc force-pushed the fix/stop-federating-message branch from 8807091 to c9d919c Compare October 11, 2023 07:15
@atomrc atomrc enabled auto-merge (squash) October 11, 2023 07:17
@atomrc atomrc merged commit fbf72ff into dev Oct 11, 2023
9 checks passed
@atomrc atomrc deleted the fix/stop-federating-message branch October 11, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykBuniX PatrykBuniX PatrykBuniX approved these changes

@tlebon tlebon tlebon approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
👕 size: S type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atomrc @tlebon @PatrykBuniX @otto-the-bot