runfix: Avoid mutliple emojis with the same key #15951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Oct 9, 2023
Comment on lines
+89
to
+91
| const emojiUsageCount: Record<string, number> = loadValue(StorageKey.CONVERSATION.EMOJI_USAGE_COUNT) || {}; | ||
|
|
||
| const getUsageCount = (emojiName: string): number => emojiUsageCount[emojiName] || 0; |
There was a problem hiding this comment.
This is a simple optimisation. This doesn't need to live in the react world
tlebon
approved these changes
Oct 9, 2023
Codecov Report
@@ Coverage Diff @@
## dev #15951 +/- ##
==========================================
- Coverage 44.67% 44.28% -0.39%
==========================================
Files 668 683 +15
Lines 22671 22919 +248
Branches 5169 5213 +44
==========================================
+ Hits 10128 10150 +22
- Misses 11245 11468 +223
- Partials 1298 1301 +3 |
przemvs
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid having those emojis displayed with the same react key (
sunglassesappear twice for example)Checklist