-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate input bar to Lexical #15507
Merged
Merged
Changes from 82 commits
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
a1c9f5d
new input bar
przemvs be253de
fix bug with letter by letter submit
thisisamir98 ac532b1
edit broken
thisisamir98 da00343
InputBar improvements
przemvs 427dd5e
use theme responsive css variables for text and bg colors
V-Gira cbc1de1
Fix mentions and emojis popover
przemvs 17003fe
finalize
przemvs 6a9dc67
refactor: move send button out of lexical input (#15505)
V-Gira 2d0869c
input bar - final version
przemvs 30bcf10
Merge branch 'dev' into feature/WPB-460-new-input-bar
przemvs d7f6805
fixes
przemvs 9df8d28
CR Fixes
przemvs 458f263
Merge branch 'dev' into feature/WPB-460-new-input-bar
przemvs 0dff08a
cr fixes
przemvs c59c5d1
spaces
przemvs 81cc7d0
Merge branch 'dev' into feature/WPB-460-new-input-bar
przemvs 88ec5cf
fixes
przemvs ba18065
Merge branch 'dev' into feature/WPB-460-new-input-bar
przemvs 356a77f
code clean-up
przemvs 0e986ce
CR Fixes
przemvs d257bb1
exports fix
przemvs b4866f8
chore: cleanup unused propertyRepo
atomrc 488690a
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc dbac8ac
chore: camel case
atomrc 7ee34b0
fix emoji detection
atomrc 79fa017
fix types
atomrc d26f4ba
fix multiple spaces emoji searching
atomrc f1b3170
feat: Replace inline emoji (#15554)
phoenixhdd 247fd4b
refactor: Simplify mention and emoji matching
atomrc 90432de
fix typing indicator + autofocus on input
atomrc 1518634
fix linting
atomrc 189406c
code review
atomrc 4f1b849
add input bar tests
atomrc d18b27c
improve typing detection
atomrc f8eb76d
ignore tests
atomrc cbc9740
fix tests
atomrc de7b7e5
cleanup custom plugins
atomrc f7bde57
fix: revert mention list
atomrc f56e864
restore copied typeahead plugin
atomrc 1159ace
fine tune mentions menu scroll
atomrc 0ff4cb9
Avoid removing/re-adding menu container on each update
atomrc d831782
add doc
atomrc f9e8e13
restore undo/redo
atomrc 1746495
reorganize components
atomrc 7756916
cleanup
atomrc 505e403
simplify emoji node
atomrc 2b53554
refactor: Streamline message sending process (#15581)
atomrc 9f2fef9
fix: detecting when enter should be disabled for sending
atomrc 57e8fc9
fix: adding emoji or mention in the middle of a message
atomrc 07e2a33
fix: inline replacing leading emoji
atomrc 7962b46
fix: inline replacement of emojis
atomrc 1a8f07e
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc 9e1ecf3
fix: Restore esc to cancel edit
atomrc 0258171
fix: Restore up arrow to edit
atomrc 58aeed8
fix: restore visual seletion of mentions
atomrc 161fcf6
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc b889c46
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc aa3718f
fix setting initial draft state
atomrc 9a84da0
fix: edit last message when hitting up arrow in mention suggestions
atomrc 742a6ff
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc ab390d7
fix: Improve autofocus plugin
atomrc 755fb89
fix: Isolate classifiedbar changes to component
atomrc efc44bd
fix tests
atomrc fa66ad9
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc af127dd
improve classified bar types and re-renders
atomrc ef61abe
fix: do not edit is input value is not empty
atomrc 3bc276f
make mentions retrieval lazy and not triggering re-render
atomrc bc7ffb9
cleanup
atomrc 44245f2
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc 402d35f
fix mention generation
atomrc 09d8fe6
fix: Do final replacement of emoji before sending the messaage
atomrc a2942da
Extract logic to separate plugins
atomrc c84a304
fix: Use emojies from the react-emoji-picker plugin
atomrc e6eea6e
fix import
atomrc 267a1ac
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc 1fa8c67
refactor: extract typing indicator to hook
atomrc de911f2
fix: restore typing stop message when editor is blurred
atomrc 2d699d6
minor improvements
atomrc 3406e68
improve useTypingIndicator code
atomrc 97bfa63
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc 95cae5d
fix: Restore esc to cancel replying
atomrc beaf068
refactor: extract message edition to a plugin
atomrc 7b060d8
refactor: move code around
atomrc 77f8910
fix: arrow press when emoji picker is opened
atomrc a300d25
move more handler to generic event handler
atomrc 7a4d20e
refactor: Extract property getter into own hook
atomrc b916ec4
refactor: do not leak properties repo in the rich text editor
atomrc 37748af
refactor: reorganize dependencies
atomrc 1403edd
doc: add comment on emoji list
atomrc 566c8d1
refactor: use text variable
atomrc 1247d2e
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc 427bbb8
fix emoji list types
atomrc 4a36da3
doc: explain the history saving delay
atomrc 1246684
ugprade deps
atomrc 9d065f2
Merge branch 'dev' into feature/WPB-460-new-input-bar
atomrc a410be7
fix emojji types
atomrc f04b2f7
fix tests
atomrc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -521,7 +521,8 @@ export const Conversation: FC<ConversationProps> = ({ | |
/> | ||
|
||
<InputBar | ||
conversationEntity={activeConversation} | ||
key={activeConversation?.id} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will reset the input bar everytime we switch conversation |
||
conversation={activeConversation} | ||
conversationRepository={repositories.conversation} | ||
eventRepository={repositories.event} | ||
messageRepository={repositories.message} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to use exact versions here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call 👌