feat: Add ability to create guest links with password (SQSERVICES-1975) #15014

thisisamir98 · 2023-04-14T14:25:05Z

SQSERVICES-1975 [web] implement flow of creating a guest link with a password

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Adds a password option when using a guest link.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…ICES-1975

codecov · 2023-04-24T11:49:19Z

Codecov Report

Merging #15014 (59d4ab0) into dev (0d0ca5b) will decrease coverage by 0.09%.
The diff coverage is 33.86%.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #15014      +/-   ##
==========================================
- Coverage   45.57%   45.49%   -0.09%     
==========================================
  Files         732      736       +4     
  Lines       23746    23964     +218     
  Branches     5405     5455      +50     
==========================================
+ Hits        10823    10903      +80     
- Misses      11549    11662     +113     
- Partials     1374     1399      +25

…ICES-1975

src/script/auth/component/GuestLinkPasswordModal.tsx

Co-authored-by: Virgile <[email protected]>

… into feat/SQSERVICES-1975

thisisamir98 · 2023-04-25T11:37:16Z

We can't merge till other platforms catch up, at least they have to implement join flow for guest links with passwords!

src/script/auth/component/GuestLinkPasswordModal.tsx

src/script/page/RightSidebar/GuestServicesOptions/components/GuestOptions/GuestOptions.tsx

przemvs · 2023-04-25T11:44:49Z

src/script/auth/page/SingleSignOnForm.tsx

+    if (!codeOrMailInput.current) {
+      return;
+    }
+


You can't move it to (isFetching || !codeOrMailInput.current) ?

done in
4cab38d

atomrc · 2023-04-25T12:00:41Z

src/i18n/en-US.json

@@ -596,6 +613,11 @@
  "guestRoomToggleInfoDisabled": "You can't disable the guest option in this conversation, as it has been created by someone from another team.",
  "guestRoomToggleInfoExtended": "Open this conversation to people outside your team. You can always change it later.",
  "guestRoomToggleInfoHead": "Guest Links",
+  "guestLinkPasswordModal.headline": "[Group Conversation] \n Enter password",


Is this \n really working 🤔 ?

yeah if you do white-space: pre or pre-line it works.

atomrc · 2023-04-25T12:06:28Z

src/script/auth/page/ConversationJoin.tsx

-          }
-        }
+      if (isBackendError(error)) {
+        handleSubmitError(error as BackendError);


Do you really need the as BackendError here? Seems like you have a typeguard above it should type it for you

Co-authored-by: Przemysław Jóźwik <[email protected]>

… into feat/SQSERVICES-1975

atomrc · 2023-11-16T16:46:06Z

src/script/util/StringUtil.ts

+ * @param {string} password - The password to be checked.
+ * @returns {boolean} True if the password meets all conditions, false otherwise.
+ */
+export function isValidPassword(password: string): boolean {


If you want to use the browser's built in method to validate inputs, you can also use regexp positive lookahead (see https://javascript.info/regexp-lookahead-lookbehind#lookahead).

The regexp would look like this

/(?=.*[a-z])(?=.*[A-Z])(?=.*[1-9])(?=.*[!@#$%^&*()_+\-=[\]{};':"\\|,.<>/?])/

updated in 45c45db

atomrc · 2023-11-16T16:53:16Z

src/script/components/Modals/PrimaryModal/PrimaryModalTypes.ts

  currentType: string;
  inputPlaceholder: string;
  messageHtml: string;
-  messageText: string;
+  messageText: React.ReactNode;


maybe we could call this one message and deprecate the messageHtml (since react node is way more suitable for the future)

ive updated this and the other modal comment in 1d4a248 but my sense is that this one is sort of unrelated to the main PR here.

atomrc · 2023-11-16T16:54:18Z

src/script/components/Modals/PrimaryModal/PrimaryModalTypes.ts

  modalUie: string;
  onBgClick: () => void;
+  passwordGenerator?: boolean;


This seems a little too specific. The Modal component should not be aware that there is a password generator that exists. I think this API can be made more generic

this one is removed, agreed its unnecessary.

thisisamir98 added 7 commits April 14, 2023 17:54

feat: Add ability to create guest links with password (SQSERVICES-1975)

2753f4d

feat: Add GuestLinkPasswordModal

07e394c

join with login

3479d34

sso password

3aa2a77

joing with deeplink

768b9d1

clean up copies

02138ec

Merge branch 'dev' of github.com:wireapp/wire-webapp into feat/SQSERV…

8314b82

…ICES-1975

otto-the-bot added type: feature / request ✨ 👕 size: XXL labels Apr 24, 2023

thisisamir98 marked this pull request as ready for review April 24, 2023 11:28

thisisamir98 requested review from a team and otto-the-bot as code owners April 24, 2023 11:28

fix error

d16bc8f

Merge branch 'dev' of github.com:wireapp/wire-webapp into feat/SQSERV…

3a63325

…ICES-1975

V-Gira reviewed Apr 25, 2023

View reviewed changes

src/script/auth/component/GuestLinkPasswordModal.tsx Outdated Show resolved Hide resolved

thisisamir98 and others added 3 commits April 25, 2023 12:28

Update src/script/auth/component/GuestLinkPasswordModal.tsx

73c5ec0

Co-authored-by: Virgile <[email protected]>

backward compatibility

c1a393a

Merge branch 'feat/SQSERVICES-1975' of github.com:wireapp/wire-webapp…

8019074

… into feat/SQSERVICES-1975

thisisamir98 added the blocked: do-not-merge label Apr 25, 2023

przemvs reviewed Apr 25, 2023

View reviewed changes

src/script/auth/component/GuestLinkPasswordModal.tsx Outdated Show resolved Hide resolved

PatrykBuniX reviewed Apr 25, 2023

View reviewed changes

src/script/page/RightSidebar/GuestServicesOptions/components/GuestOptions/GuestOptions.tsx Show resolved Hide resolved

przemvs reviewed Apr 25, 2023

View reviewed changes

atomrc reviewed Apr 25, 2023

View reviewed changes

thisisamir98 and others added 4 commits April 26, 2023 11:27

Update src/script/auth/component/GuestLinkPasswordModal.tsx

fc0df1a

Co-authored-by: Przemysław Jóźwik <[email protected]>

use on if

4cab38d

Merge branch 'feat/SQSERVICES-1975' of github.com:wireapp/wire-webapp…

498955a

… into feat/SQSERVICES-1975

fix backenderror

9f0be47

tlebon force-pushed the feat/SQSERVICES-1975 branch 4 times, most recently from 1d8e6a5 to 0976347 Compare November 1, 2023 15:19

fix: issue with some edge cases not working

e8967d0

tlebon force-pushed the feat/SQSERVICES-1975 branch from 0976347 to e8967d0 Compare November 2, 2023 10:25

tlebon added 2 commits November 9, 2023 14:49

chore: merge dev

c02ea4b

chore: remove error throw

0c84609

tlebon force-pushed the feat/SQSERVICES-1975 branch from ae8d5c5 to 0c84609 Compare November 9, 2023 15:39

fix: remove form param submission bug

5e70571

tlebon force-pushed the feat/SQSERVICES-1975 branch from 73818a4 to 5e70571 Compare November 9, 2023 16:29

tlebon added 4 commits November 13, 2023 13:20

chore: remove password from error on L132

72a0561

chore: missing error catch

c643e5f

feat: possible fix for open issues

ccfc429

fix: password verification

c94981f

atomrc reviewed Nov 16, 2023

View reviewed changes

tlebon added 2 commits November 20, 2023 17:56

chore: condense password regex

45c45db

feat: update primary modal

772e337

tlebon force-pushed the feat/SQSERVICES-1975 branch from 1d4a248 to 772e337 Compare November 22, 2023 09:35

chore: disable guest link passwords feature

6f16f41

tlebon removed the blocked: do-not-merge label Nov 27, 2023

aweiss-dev approved these changes Dec 15, 2023

View reviewed changes

chore: merge dev

6164354

otto-the-bot added the comp: infrastructure label Dec 19, 2023

chore: merge dev

59d4ab0

tlebon force-pushed the feat/SQSERVICES-1975 branch from 9e201f8 to 59d4ab0 Compare December 19, 2023 13:05

tlebon merged commit e820de8 into dev Dec 20, 2023
10 checks passed

tlebon deleted the feat/SQSERVICES-1975 branch December 20, 2023 09:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add ability to create guest links with password (SQSERVICES-1975) #15014

feat: Add ability to create guest links with password (SQSERVICES-1975) #15014

thisisamir98 commented Apr 14, 2023 •

edited by github-actions bot

Loading

codecov bot commented Apr 24, 2023 •

edited

Loading

thisisamir98 commented Apr 25, 2023

przemvs Apr 25, 2023

thisisamir98 Apr 26, 2023

atomrc Apr 25, 2023

thisisamir98 Apr 26, 2023

atomrc Apr 25, 2023

thisisamir98 Apr 26, 2023

atomrc Nov 16, 2023 •

edited

Loading

tlebon Nov 20, 2023

atomrc Nov 16, 2023

tlebon Nov 20, 2023 •

edited

Loading

atomrc Nov 16, 2023

tlebon Nov 20, 2023

feat: Add ability to create guest links with password (SQSERVICES-1975) #15014

feat: Add ability to create guest links with password (SQSERVICES-1975) #15014

Conversation

thisisamir98 commented Apr 14, 2023 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Causes (Optional)

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

codecov bot commented Apr 24, 2023 • edited Loading

Codecov Report

thisisamir98 commented Apr 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atomrc Nov 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tlebon Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thisisamir98 commented Apr 14, 2023 •

edited by github-actions bot

Loading

codecov bot commented Apr 24, 2023 •

edited

Loading

atomrc Nov 16, 2023 •

edited

Loading

tlebon Nov 20, 2023 •

edited

Loading