fix: Do not show notification when call feedback is skipped

wireapp · Dec 19, 2024 · efc6e22 · efc6e22
1 parent 341b898
commit efc6e22
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/script/components/Modals/QualityFeedbackModal/QualityFeedbackModal.tsx b/src/script/components/Modals/QualityFeedbackModal/QualityFeedbackModal.tsx
@@ -66,7 +66,7 @@ export const QualityFeedbackModal = () => {
     return null;
   }
 
-  const handleCloseModal = () => {
+  const handleCloseModal = (skipNotification = false) => {
     if (!selfUser) {
       setQualityFeedbackModalShown(false);
       return;
@@ -80,7 +80,10 @@ export const QualityFeedbackModal = () => {
 
       currentStorageData[selfUser.id] = isChecked ? null : dateUntilShowModal.getTime();
       localStorage.setItem(CALL_QUALITY_FEEDBACK_KEY, JSON.stringify(currentStorageData));
-      submittedNotification.show();
+
+      if (!skipNotification) {
+        submittedNotification.show();
+      }
     } catch (error) {
       logger.warn(`Can't send feedback: ${(error as Error).message}`);
     } finally {
@@ -102,7 +105,7 @@ export const QualityFeedbackModal = () => {
       [Segmentation.CALL.QUALITY_REVIEW_LABEL]: RatingListLabel.DISMISSED,
     });
 
-    handleCloseModal();
+    handleCloseModal(true);
   };
 
   return (

diff --git a/src/types/i18n.d.ts b/src/types/i18n.d.ts
@@ -1630,7 +1630,7 @@ declare module 'I18n/en-US.json' {
     'videoCallOverlayViewModeSpeakers': `Show active speakers only`;
     'videoCallParticipantConnecting': `Connecting...`;
     'videoCallParticipantLowerYourHand': `Lower your hand`;
-    'videoCallParticipantPressSpaceToUnmuteNotification': `Microphone temporarily on`;
+    'videoCallParticipantPressSpaceToUnmuteNotification': `Your microphone is on`;
     'videoCallParticipantRaiseYourHand': `Raise your hand`;
     'videoCallParticipantRaisedHandRaiseDuration': `Hand raised for {duration}`;
     'videoCallParticipantRaisedSelfHandUp': `You have raised your hand up`;