runfix: Avoid sending countly device ID before self conversation is j…

…oined
wireapp · Jan 18, 2024 · df48f9d · df48f9d
1 parent 8863c3c
commit df48f9d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/script/main/app.ts b/src/script/main/app.ts
@@ -492,10 +492,10 @@ export class App {
       telemetry.timeStep(AppInitTimingsStep.UPDATED_FROM_NOTIFICATIONS);
       telemetry.addStatistic(AppInitStatisticsValue.NOTIFICATIONS, totalNotifications, 100);
 
-      eventTrackerRepository.init(propertiesRepository.properties.settings.privacy.telemetry_sharing);
       onProgress(97.5, t('initUpdatedFromNotifications', this.config.BRAND_NAME));
 
       const clientEntities = await clientRepository.updateClientsForSelf();
+      await eventTrackerRepository.init(propertiesRepository.properties.settings.privacy.telemetry_sharing);
 
       onProgress(99);
 

diff --git a/src/script/mls/MLSConversations.ts b/src/script/mls/MLSConversations.ts
@@ -75,10 +75,7 @@ export async function initMLSGroupConversations(
 
       //otherwise we should try joining via external commit
       await conversationService.joinByExternalCommit(qualifiedId);
-
-      if (onSuccessfulJoin) {
-        return onSuccessfulJoin(mlsConversation);
-      }
+      onSuccessfulJoin?.(mlsConversation);
     } catch (error) {
       onError?.(mlsConversation, error);
     }