fix: Wrong copy in tooltips for the green shields of users and conver…

…sations (#16991)
wireapp · Mar 4, 2024 · bd489a2 · bd489a2
1 parent 90827f2
commit bd489a2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/i18n/en-US.json b/src/i18n/en-US.json
@@ -58,6 +58,7 @@
   "E2EI.certificateNotDownloaded": "End-to-end identity certificate not downloaded",
   "E2EI.certificateRevoked": "End-to-end identity certificate revoked",
   "E2EI.certificateTitle": "End-to-end identity certificate",
+  "E2EI.conversationVerified": "Conversation verified (End-to-end identity)",
   "E2EI.copyCertificate": "Copy to Clipboard",
   "E2EI.deviceVerified": "Device verified (End-to-end identity)",
   "E2EI.downloadCertificate": "Download",
@@ -72,6 +73,7 @@
   "E2EI.showCertificateDetails": "Show Certificate Details",
   "E2EI.status": "Status:",
   "E2EI.updateCertificate": "Update Certificate",
+  "E2EI.userDevicesVerified": "All devices verified (End-to-end identity)",
   "E2EI.valid": "Valid",
   "E2EI.verified": "Verified (End-to-end Identity)",
   "LOGOUT_REASON.ACCOUNT_REMOVED": "You were signed out because your account was deleted.",
@@ -1533,4 +1535,4 @@
   "wireMacos": "{{brandName}} for macOS",
   "wireWindows": "{{brandName}} for Windows",
   "wire_for_web": "{{brandName}} for Web"
-}
+}
diff --git a/src/script/components/VerificationBadge/VerificationBadges.tsx b/src/script/components/VerificationBadge/VerificationBadges.tsx
@@ -38,9 +38,10 @@ import {Conversation} from 'src/script/entity/Conversation';
 import {User} from 'src/script/entity/User';
 import {useUserIdentity} from 'src/script/hooks/useDeviceIdentities';
 import {useKoSubscribableChildren} from 'Util/ComponentUtil';
-import {t} from 'Util/LocalizerUtil';
+import {StringIdentifer, t} from 'Util/LocalizerUtil';
 
 type VerificationBadgeContext = 'user' | 'conversation' | 'device';
+
 interface VerificationBadgesProps {
   conversationProtocol?: ConversationProtocol;
   isProteusVerified?: boolean;
@@ -131,8 +132,14 @@ const MLSVerificationBadge = ({context, MLSStatus}: {MLSStatus?: MLSStatuses; co
 
   switch (MLSStatus) {
     case MLSStatuses.VALID:
+      const translationKeys: Record<VerificationBadgeContext, StringIdentifer> = {
+        conversation: 'E2EI.conversationVerified',
+        user: 'E2EI.userDevicesVerified',
+        device: 'E2EI.deviceVerified',
+      };
+
       return (
-        <Tooltip body={t('E2EI.deviceVerified')} {...mlsVerificationProps}>
+        <Tooltip body={t(translationKeys[context])} {...mlsVerificationProps}>
           <MLSVerified />
         </Tooltip>
       );