runfix: remove slashes from conversation and user api constants #6727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemvs
approved these changes
Dec 4, 2024
e-maad
reviewed
Dec 4, 2024
| @@ -171,7 +171,7 @@ export class UserAPI { | |||
| * @see https://staging-nginz-https.zinfra.io/swagger-ui/#!/users/getUserClient | |||
| */ | |||
| public async getClient(userId: QualifiedId, clientId: string): Promise<PublicClient> { | |||
| const url = `${UserAPI.URL.USERS}/${userId.domain}/${userId.id}/${UserAPI.URL.CLIENTS}/${clientId}`; | |||
| const url = `//${UserAPI.URL.USERS}/${userId.domain}/${userId.id}/${UserAPI.URL.CLIENTS}/${clientId}`; | |||
przemvs
reviewed
Dec 4, 2024
| @@ -190,7 +190,7 @@ export class UserAPI { | |||
| */ | |||
| public async getClientPreKey(userId: QualifiedId, clientId: string): Promise<ClientPreKey> { | |||
| const {id, domain} = userId; | |||
| const url = `${UserAPI.URL.USERS}/${domain}/${id}/${UserAPI.URL.PRE_KEYS}/${clientId}`; | |||
| const url = `//${UserAPI.URL.USERS}/${domain}/${id}/${UserAPI.URL.PRE_KEYS}/${clientId}`; | |||
przemvs
reviewed
Dec 4, 2024
| @@ -206,7 +206,7 @@ export class UserAPI { | |||
| * @see https://staging-nginz-https.zinfra.io/swagger-ui/#!/users/getUserClients | |||
| */ | |||
| public async getClients(userId: QualifiedId): Promise<PublicClient[]> { | |||
| const url = `${UserAPI.URL.USERS}/${userId.domain}/${userId.id}/${UserAPI.URL.CLIENTS}`; | |||
| const url = `//${UserAPI.URL.USERS}/${userId.domain}/${userId.id}/${UserAPI.URL.CLIENTS}`; | |||
przemvs
reviewed
Dec 4, 2024
| @@ -723,7 +723,7 @@ export class UserAPI { | |||
| const config: AxiosRequestConfig = { | |||
| data: {email}, | |||
| method: 'put', | |||
| url: `${UserAPI.URL.USERS}/${userId}/${UserAPI.URL.EMAIL}`, | |||
| url: `//${UserAPI.URL.USERS}/${userId}/${UserAPI.URL.EMAIL}`, | |||
|
paulwire
added
the
echoes: technical-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slashes are hardcoded into some of the url constants in the conversation and user api;
This remove those slashes, allowing us to use those constant where the API endpoints change the order around, as is the case for V&, see https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/1309868033/API+changes+v6+v7
Checklist