feat: try establishing mls group for mixed conversation #5578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
reviewed
Oct 9, 2023
| * @param selfUserId - id of the self user | ||
| * @param qualifiedUsers - list of qualified users to add to the group (should not include the self user) | ||
| */ | ||
| public async tryEstablishingMLSGroupWithUsers({ |
There was a problem hiding this comment.
Suggested change
| public async tryEstablishingMLSGroupWithUsers({ | |
| public async tryEstablishingMLSGroup({ |
Let's shorten the naming a little. It's explicit that you can add users since it's in the param payload
atomrc
approved these changes
Oct 9, 2023
atomrc
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method for trying to establish a mls group for mixed conversation. This logic did previously live in webapp, but since it's plain core/mls logic, it can be moved to core package's
ConversationService.