Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(wire-webapp): Remove slug from legal hold support URL #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(wire-webapp): Remove slug from legal hold support URL #100

wants to merge 1 commit into from

Conversation

bennycode
Copy link
Contributor

URLs are more stable when removing the slug and just keeping the ID. In this case the URL does not break when the title of the post is changed.

@Yserz Yserz changed the title refactor(webapp): Remove slug from legal hold support URL refactor(wire-webapp): Remove slug from legal hold support URL May 26, 2021
ffflorian
ffflorian approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@ffflorian ffflorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a chore, isn't it?

@CLAassistant
Copy link

CLAassistant commented May 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffflorian ffflorian ffflorian approved these changes

@Yserz Yserz Yserz approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bennycode @CLAassistant @Yserz @ffflorian